Re: [ACPI] Re: [Proposal]Another way to save/restore PCI config space for suspend/resume

Re: [ACPI] Re: [Proposal]Another way to save/restore PCI config space for suspend/resume

[Len Brown]

Li Shaohua wrote:
> On Tue, 2004-10-26 at 17:21, Pavel Machek wrote:

>>>Here is a another idea: 
>>>Record all PCI writes in Linux kernel...
>>
>>That looks extremely ugly to me. If you want to do something special
>>in resume function, just do it there. It will probably share a lot of
>>code with your init function, anyway.
> 
> How can you handle devices without driver? And how to save/restore
> config space for special devices, such as LPC bridge and host bridge?

Say that writing the missing drivers is the only workable solution.
Does anybody have an estimate of how many there are and how big
a task that would be?

-Len

Re: [ACPI] Re: [Proposal]Another way to save/restore PCI config space for suspend/resume

[Benjamin Herrenschmidt]

On Wed, 2004-10-27 at 02:30 -0400, Len Brown wrote:
> Li Shaohua wrote:
> > On Tue, 2004-10-26 at 17:21, Pavel Machek wrote:
> 
> >>>Here is a another idea: 
> >>>Record all PCI writes in Linux kernel...
> >>
> >>That looks extremely ugly to me. If you want to do something special
> >>in resume function, just do it there. It will probably share a lot of
> >>code with your init function, anyway.
> > 
> > How can you handle devices without driver? And how to save/restore
> > config space for special devices, such as LPC bridge and host bridge?
> 
> Say that writing the missing drivers is the only workable solution.
> Does anybody have an estimate of how many there are and how big
> a task that would be?

This has been discussed a bit on linux-pm (on osdl lists, it's a new
list to discuss PM specific matters). I tend to think the core should
know at least a few "standard" things like P2P bridges, by simply
saving/restoring a bigger chunk of config space. We also need to fix the
current restore code I suppose, so that it disables IO & MEM, then
restore all registers, then re-enable those 2 ones...

I don't want to cross-post between lists, but people are welcome to join
linux-pm to talk about implementation issues related to power
management, including the changes we are trying to define to the various
driver callbacks. 

Ben.

[Proposal]Another way to save/restore PCI config space for suspend/resume

[Li Shaohua]

Hi,
We suffer from PCI config space issue for a long time, which causes many
system can't correctly resume. Current Linux mechanism isn't sufficient.
Here is a another idea: 
Record all PCI writes in Linux kernel, and redo all the write after
resume in order. The idea assumes Firmware will restore all PCI config
space to the boot time state, which is true at least for IA32.

Reason:
1. Current PCI save/restore routines only cover first 64 bytes
2. No PCI bridge driver currently.
3. Some special devices can't or are difficult to save/restore config
space with current model. Such as PCI link device, it's a sysdev, but
its resume code can't be invoked with irq disabled.
4. ACPI possibly changes special devices' config space, such as host
bridge or LPC bridge. The special devices generally are vender specific,
and possibly will not have a driver forever.

Possibly we must consider other factors:
1.tracking writes alone will not be enough. Some PCI devices may have
restrictions such as something has to be written after it is read and
the like. Still we should be able to do this if we can trace all pci
reads and writes and repeat it at restore.
2. For support hotplug, add a callback for hotplug PCI remove. When a
device is removed, all records about it are removed.
What's your opinions?

Thanks,
Shaohua

Re: [Proposal]Another way to save/restore PCI config space for suspend/resume

[Pavel Machek]

Hi!

> We suffer from PCI config space issue for a long time, which causes many
> system can't correctly resume. Current Linux mechanism isn't sufficient.
> Here is a another idea: 
> Record all PCI writes in Linux kernel, and redo all the write after
> resume in order. The idea assumes Firmware will restore all PCI config
> space to the boot time state, which is true at least for IA32.

That looks extremely ugly to me. If you want to do something special
in resume function, just do it there. It will probably share a lot of
code with your init function, anyway.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

Re: [ACPI] Re: [Proposal]Another way to save/restore PCI config space for suspend/resume

[Li Shaohua]

On Tue, 2004-10-26 at 17:21, Pavel Machek wrote:
> Hi!
> 
> > We suffer from PCI config space issue for a long time, which causes many
> > system can't correctly resume. Current Linux mechanism isn't sufficient.
> > Here is a another idea: 
> > Record all PCI writes in Linux kernel, and redo all the write after
> > resume in order. The idea assumes Firmware will restore all PCI config
> > space to the boot time state, which is true at least for IA32.
> 
> That looks extremely ugly to me. If you want to do something special
> in resume function, just do it there. It will probably share a lot of
> code with your init function, anyway.
How can you handle devices without driver? And how to save/restore
config space for special devices, such as LPC bridge and host bridge?

-Shaohua