Re: ppc: fix up pmac IDE driver for driver core changes

Re: ppc: fix up pmac IDE driver for driver core changes

[Benjamin Herrenschmidt]

On Sat, 2004-11-13 at 20:53 +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2115, 2004/11/13 12:53:51-08:00, torvalds@ppc970.osdl.org
> 
> 	ppc: fix up pmac IDE driver for driver core changes
> 	
> 	device power state is in "dev.power.power_state" now, rather than
> 	in "dev.power_state".
> 

Hrm... Missed that core change, where does it come from ? doesn't quite
go in the direction we have been discussing on linux-pm lately, which
is rather to remove this power_state field entirely since it's mostly
meaningless at this point (or rather, it's semantics are confuse and the
userland interface to it is means pretty much nothing).

While having a power_state field here for internal use of the driver may
be "useful" (avoiding the need for drivers to maintain something
equivalent locally), it's pretty much impossible to have a generic
abstract power_state that has globally defined semantics, at least not
with our current scheme.

Ben.

Re: ppc: fix up pmac IDE driver for driver core changes

[Linus Torvalds]

On Sun, 14 Nov 2004, Benjamin Herrenschmidt wrote:
> On Sat, 2004-11-13 at 20:53 +0000, Linux Kernel Mailing List wrote:
> > ChangeSet 1.2115, 2004/11/13 12:53:51-08:00, torvalds@ppc970.osdl.org
> > 
> > 	ppc: fix up pmac IDE driver for driver core changes
> > 	
> > 	device power state is in "dev.power.power_state" now, rather than
> > 	in "dev.power_state".
> > 
> 
> Hrm... Missed that core change, where does it come from ?

It's the core "struct device" shrinkage patch:

	ChangeSet@1.2092.3.1, 2004-11-12 11:41:25-08:00, david-b@pacbell.net
	  [PATCH] driver core: shrink struct device a bit
  
	  This patch removes two fields from "struct device" that are duplicated
	  in "struct dev_pm_info":  power_state (which should probably vanish)
	  and "saved_state".  There were only two "real" uses of saved_state;
	  both are now switched over to use dev_pm_info.
  
	  Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
	  Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

so I think the people involved agree with you on moving it ever outwards..

		Linus