public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	torvalds@osdl.org
Subject: Potential security problem in patch: Fix reading /proc/<pid>/mem when parent dies.
Date: Thu, 18 Nov 2004 23:27:56 +0000	[thread overview]
Message-ID: <1100820455.6019.31.camel@localhost.localdomain> (raw)
In-Reply-To: <200411181704.iAIH4SSb023079@hera.kernel.org>

On Iau, 2004-11-18 at 16:01, Linux Kernel Mailing List wrote:
> ChangeSet 1.2155, 2004/11/18 08:01:00-08:00, torvalds@ppc970.osdl.org
> 
> 	Fix reading /proc/<pid>/mem when parent dies.
> 	
> 	We should not touch "self_exec_id" here. The parent changed,
> 	not we.

The original point of this was that if our parent changed then our new
parent is not aware of our special status. As a result we can send
random signals to init and since it does not see SIGCLD we can get
zombies or worse when we exit.

The original code was correct here for protecting init. The side effect
does need fixing but not this way. Perhaps it would be simpler just to
protect init as it is already "special" for signal handling.

Alan


       reply	other threads:[~2004-11-19  0:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200411181704.iAIH4SSb023079@hera.kernel.org>
2004-11-18 23:27 ` Alan Cox [this message]
2004-11-19  0:52   ` Potential security problem in patch: Fix reading /proc/<pid>/mem when parent dies Linus Torvalds
2004-11-19  0:00     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100820455.6019.31.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox