public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Potential security problem in patch: Fix reading /proc/<pid>/mem when parent dies.
Date: Fri, 19 Nov 2004 00:00:59 +0000	[thread overview]
Message-ID: <1100822457.6579.53.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0411181648040.2222@ppc970.osdl.org>

On Gwe, 2004-11-19 at 00:52, Linus Torvalds wrote:
> How could we send random signals? That's what the "exit_signal" thing is 
> for, and the code does
> 
> 	if (p->exit_signal != -1)
> 		p->exit_signal = SIGCHLD;
> 
> for that.
> 
> Is there any other way to set exit_signal afterwards? If so, I think we 
> should have a security check at _that_ point.

Ok that makes sense now I look harder at it. While it was added to
protect agains that case the code you quote already covers all the cases
I can see. We can clone new threads but they too will get reparented or
will simply kill us.



      reply	other threads:[~2004-11-19  1:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200411181704.iAIH4SSb023079@hera.kernel.org>
2004-11-18 23:27 ` Potential security problem in patch: Fix reading /proc/<pid>/mem when parent dies Alan Cox
2004-11-19  0:52   ` Linus Torvalds
2004-11-19  0:00     ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100822457.6579.53.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox