* [PATCH 0/1] VFS: memory leak in do_kern_mount()
@ 2005-06-17 13:17 Gerald Schaefer
2005-06-17 15:47 ` Gerald Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Gerald Schaefer @ 2005-06-17 13:17 UTC (permalink / raw)
To: akpm; +Cc: schwidefsky, linux-kernel
[PATCH 0/1] VFS: memory leak in do_kern_mount()
There is a memory leak during mount when CONFIG_SECURITY is enabled and mount
options are specified.
Signed-off-by: Gerald Schaefer <geraldsc@de.ibm.com>
---
diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
--- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
+++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
@@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
mnt->mnt_parent = mnt;
mnt->mnt_namespace = current->namespace;
up_write(&sb->s_umount);
+ free_secdata(secdata);
put_filesystem(type);
return mnt;
out_sb:
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 0/1] VFS: memory leak in do_kern_mount()
2005-06-17 13:17 [PATCH 0/1] VFS: memory leak in do_kern_mount() Gerald Schaefer
@ 2005-06-17 15:47 ` Gerald Schaefer
2005-06-17 19:49 ` James Morris
0 siblings, 1 reply; 3+ messages in thread
From: Gerald Schaefer @ 2005-06-17 15:47 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, schwidefsky
On Fri, 2005-06-17 at 15:17 +0200, Gerald Schaefer wrote:
> [PATCH 0/1] VFS: memory leak in do_kern_mount()
> There is a memory leak during mount when CONFIG_SECURITY is enabled and mount
> options are specified.
>
> Signed-off-by: Gerald Schaefer <geraldsc@de.ibm.com>
> ---
>
> diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
> --- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
> +++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
> @@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
> mnt->mnt_parent = mnt;
> mnt->mnt_namespace = current->namespace;
> up_write(&sb->s_umount);
> + free_secdata(secdata);
> put_filesystem(type);
> return mnt;
> out_sb:
Sorry, there was a whitespace accident and the above patch would not apply.
Here is the fixed version:
diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
--- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
+++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
@@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
mnt->mnt_parent = mnt;
mnt->mnt_namespace = current->namespace;
up_write(&sb->s_umount);
+ free_secdata(secdata);
put_filesystem(type);
return mnt;
out_sb:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/1] VFS: memory leak in do_kern_mount()
2005-06-17 15:47 ` Gerald Schaefer
@ 2005-06-17 19:49 ` James Morris
0 siblings, 0 replies; 3+ messages in thread
From: James Morris @ 2005-06-17 19:49 UTC (permalink / raw)
To: Gerald Schaefer; +Cc: akpm, linux-kernel, schwidefsky
On Fri, 17 Jun 2005, Gerald Schaefer wrote:
> Sorry, there was a whitespace accident and the above patch would not apply.
> Here is the fixed version:
>
> diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
> --- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
> +++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
> @@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
> mnt->mnt_parent = mnt;
> mnt->mnt_namespace = current->namespace;
> up_write(&sb->s_umount);
> + free_secdata(secdata);
> put_filesystem(type);
> return mnt;
> out_sb:
Acked-by: James Morris <jmorris@redhat.com>
- James
--
James Morris
<jmorris@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-06-17 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-17 13:17 [PATCH 0/1] VFS: memory leak in do_kern_mount() Gerald Schaefer
2005-06-17 15:47 ` Gerald Schaefer
2005-06-17 19:49 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox