From: Richard Purdie <rpurdie@rpsys.net>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Pavel Machek <pavel@ucw.cz>,
lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix compilation in collie.c
Date: Mon, 25 Jul 2005 00:02:04 +0100 [thread overview]
Message-ID: <1122246124.7585.112.camel@localhost.localdomain> (raw)
In-Reply-To: <20050724233503.C20019@flint.arm.linux.org.uk>
On Sun, 2005-07-24 at 23:35 +0100, Russell King wrote:
> I'd like John (or someone) to look at this. I'm particularly worred
> about:
>
> 1. passing NULL into (read|write)_scoop_reg() - which use dev_get_drvdata()
> on this. Given the choice between creating code which will definitely
> oops but not error or warn vs not compiling, I'll take not compiling
> any day.
They should read write_scoop_reg(&colliescoop_device.dev, ...); in this
case.
There is a similar problem with drivers/input/keyboard/corgikbd.c for
which the patch has been in the input maintainer's queue for months :-(.
> 2. whether this is supposed to be using the sharp chip driver rather
> than the cfi stuff.
I think the aim was to use the cfi code but there were problems with it
not working so the sharp chip driver was being used in the meantime.
John will hopefully be able to comment more about this.
Richard
next prev parent reply other threads:[~2005-07-24 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-21 5:25 [patch] fix compilation in collie.c Pavel Machek
2005-07-24 22:35 ` Russell King
2005-07-24 23:02 ` Richard Purdie [this message]
2005-07-25 2:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122246124.7585.112.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox