From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix compilation in collie.c
Date: Sun, 24 Jul 2005 23:35:03 +0100 [thread overview]
Message-ID: <20050724233503.C20019@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050721052527.GC7849@elf.ucw.cz>; from pavel@ucw.cz on Thu, Jul 21, 2005 at 07:25:27AM +0200
On Thu, Jul 21, 2005 at 07:25:27AM +0200, Pavel Machek wrote:
> This fixes wrong number of arguments in call to write_scoop_reg, fixes
> map_name and John's email. Please apply,
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
Nacked.
I'd like John (or someone) to look at this. I'm particularly worred
about:
1. passing NULL into (read|write)_scoop_reg() - which use dev_get_drvdata()
on this. Given the choice between creating code which will definitely
oops but not error or warn vs not compiling, I'll take not compiling
any day.
2. whether this is supposed to be using the sharp chip driver rather
than the cfi stuff.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-07-24 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-21 5:25 [patch] fix compilation in collie.c Pavel Machek
2005-07-24 22:35 ` Russell King [this message]
2005-07-24 23:02 ` Richard Purdie
2005-07-25 2:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050724233503.C20019@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox