The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Luca Falavigna <dktrkranz@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration
Date: Mon, 01 Aug 2005 17:24:57 -0400	[thread overview]
Message-ID: <1122931497.6759.47.camel@localhost.localdomain> (raw)
In-Reply-To: <20050801210324.GA21087@elte.hu>

On Mon, 2005-08-01 at 23:03 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > -	struct semaphore stop;
> > +	struct compat_semaphore stop;
> 
> i think it's policy->lock that is the issue here?
> 

I was looking at Luca's original message where he showed the bug of 
-- drivers/char/watchdog/cpu5wdt.c: "cpu5wdt: Unknown symbol
there_is_no_init_MUTEX_LOCKED_for_RT_semaphores") --
Looking into this file the only init_MUTEX_LOCKED that I found was 

static int __devinit cpu5wdt_init(void)
{
	unsigned int val;
	int err;

[...]

	/* watchdog reboot? */
	val = inb(port + CPU5WDT_STATUS_REG);
	val = (val >> 2) & 1;
	if ( !val )
		printk(KERN_INFO PFX "sorry, was my fault\n");

	init_MUTEX_LOCKED(&cpu5wdt_device.stop);
	cpu5wdt_device.queue = 0;

	clear_bit(0, &cpu5wdt_device.inuse);



Here I see that cpu5wdt_device.stop is being initialized with
init_MUTEX_LOCKED, so that is what I went to fix.  I even added the
driver to my config and compiled it before sending it in.  I don't have
the device, but the driver compiled :-)

-- Steve



  reply	other threads:[~2005-08-01 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 16:26 [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration Luca Falavigna
2005-08-01 18:57 ` Steven Rostedt
2005-08-01 19:05   ` Luca Falavigna
2005-08-01 19:13     ` Sven-Thorsten Dietrich
2005-08-01 19:26       ` Steven Rostedt
2005-08-01 21:03   ` Ingo Molnar
2005-08-01 21:24     ` Steven Rostedt [this message]
2005-08-01 21:28       ` Ingo Molnar
2005-08-01 20:50 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1122931497.6759.47.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=dktrkranz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox