The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Luca Falavigna <dktrkranz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, mingo@elte.hu
Subject: Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration
Date: Mon, 1 Aug 2005 19:05:58 +0000	[thread overview]
Message-ID: <ff1cadb205080112051847d6eb@mail.gmail.com> (raw)
In-Reply-To: <1122922658.6759.22.camel@localhost.localdomain>

> Ingo purposely put this in to crash
> the compile so that we know where this can be a problem right away.
And it works nice ;)

> The patch you wanted to send was:
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> 
> Index: linux_realtime_ernie/drivers/char/watchdog/cpu5wdt.c
> ===================================================================
> --- linux_realtime_ernie/drivers/char/watchdog/cpu5wdt.c        (revision 265)
> +++ linux_realtime_ernie/drivers/char/watchdog/cpu5wdt.c        (working copy)
> @@ -56,7 +56,7 @@
>  /* some device data */
> 
>  static struct {
> -       struct semaphore stop;
> +       struct compat_semaphore stop;
>         volatile int running;
>         struct timer_list timer;
>         volatile int queue;

Another solution could be this (as shown in drivers/cpufreq/cpufreq.c):
-	init_MUTEX_LOCKED(&policy->lock);
+	init_MUTEX(&policy->lock);
+	down(&policy->lock);

  reply	other threads:[~2005-08-01 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 16:26 [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration Luca Falavigna
2005-08-01 18:57 ` Steven Rostedt
2005-08-01 19:05   ` Luca Falavigna [this message]
2005-08-01 19:13     ` Sven-Thorsten Dietrich
2005-08-01 19:26       ` Steven Rostedt
2005-08-01 21:03   ` Ingo Molnar
2005-08-01 21:24     ` Steven Rostedt
2005-08-01 21:28       ` Ingo Molnar
2005-08-01 20:50 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff1cadb205080112051847d6eb@mail.gmail.com \
    --to=dktrkranz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox