public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: stable@kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: stable review patch - ALSA ALC800 codec
Date: Thu, 24 Nov 2005 07:23:13 -0500	[thread overview]
Message-ID: <1132834994.20390.4.camel@mindpipe> (raw)

This fixes an apparent copy and paste bug that has really been causing
problems for a lot of users.  It closes ~10 different ALSA bug reports,
see #1563 for example.  Please apply ASAP for -stable.

Lee

This patch is to fix the problem of calculating the nid incorrectly when
auto-probe for ALC880. The problem to be fixed often behaves with such
words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for
ALC880.

The patch contains:
- alsa-kernel/pci/hda/patch_realtek.c: replace 'alc880_dac_to_idx' with
'alc880_idx_to_dac' in function 'alc880_auto_fill_dac_nids()'

Signed-off-by: Libin Yang <libin.yang@intel.com>


--- alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
 		nid = cfg->line_out_pins[i];
 		if (alc880_is_fixed_pin(nid)) {
 			int idx = alc880_fixed_pin_idx(nid);
-			spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+			spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
 			assigned[idx] = 1;
 		}
 	}



             reply	other threads:[~2005-11-24 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-24 12:23 Lee Revell [this message]
2005-11-28 22:56 ` [stable] stable review patch - ALSA ALC800 codec Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132834994.20390.4.camel@mindpipe \
    --to=rlrevell@joe-job.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox