* stable review patch - ALSA ALC800 codec
@ 2005-11-24 12:23 Lee Revell
2005-11-28 22:56 ` [stable] " Chris Wright
0 siblings, 1 reply; 2+ messages in thread
From: Lee Revell @ 2005-11-24 12:23 UTC (permalink / raw)
To: linux-kernel; +Cc: stable, Takashi Iwai
This fixes an apparent copy and paste bug that has really been causing
problems for a lot of users. It closes ~10 different ALSA bug reports,
see #1563 for example. Please apply ASAP for -stable.
Lee
This patch is to fix the problem of calculating the nid incorrectly when
auto-probe for ALC880. The problem to be fixed often behaves with such
words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for
ALC880.
The patch contains:
- alsa-kernel/pci/hda/patch_realtek.c: replace 'alc880_dac_to_idx' with
'alc880_idx_to_dac' in function 'alc880_auto_fill_dac_nids()'
Signed-off-by: Libin Yang <libin.yang@intel.com>
--- alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c 2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c 2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
nid = cfg->line_out_pins[i];
if (alc880_is_fixed_pin(nid)) {
int idx = alc880_fixed_pin_idx(nid);
- spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+ spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
assigned[idx] = 1;
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [stable] stable review patch - ALSA ALC800 codec
2005-11-24 12:23 stable review patch - ALSA ALC800 codec Lee Revell
@ 2005-11-28 22:56 ` Chris Wright
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wright @ 2005-11-28 22:56 UTC (permalink / raw)
To: Lee Revell; +Cc: linux-kernel, Takashi Iwai, stable
* Lee Revell (rlrevell@joe-job.com) wrote:
> This fixes an apparent copy and paste bug that has really been causing
> problems for a lot of users. It closes ~10 different ALSA bug reports,
> see #1563 for example. Please apply ASAP for -stable.
Please resend when this is fixed in Linus' tree. Also, some patch
nitpicks...make sure to add From: line to first line of changelog
comments to keep proper authorship when you are forwarding someone
else's patch, and make sure it applies to kernel tree please
(s/alsa-kernel/sound/ for example).
thanks,
-chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-28 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-24 12:23 stable review patch - ALSA ALC800 codec Lee Revell
2005-11-28 22:56 ` [stable] " Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox