From: "Nicholas A. Bellinger" <nab@kernel.org>
To: Open iSCSI <open-iscsi@googlegroups.com>,
iet-dev <iscsitarget-devel@lists.sourceforge.net>,
linux-scsi <linux-scsi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: core-iscsi v1.6.2.1 STABLE
Date: Tue, 06 Dec 2005 11:33:05 -0800 [thread overview]
Message-ID: <1133897585.32388.5.camel@haakon> (raw)
Greetings all!
Attached is a new release of the core-iscsi stack that solves one of the
items from RELEASE_NOTES (Netapp, Wasabi, SANRAD support) as well as a
additional fix related to iSCSI Underflow handling involving the removal
of a unnecessary 'return on error' condition. A big thanks to Dominik
and Dustin @ VBI for making this release happen!
These are both a single line change, please see the code below:
http://www.kernel.org/pub/linux/kernel/people/nab/iscsi-initiator-core/core-iscsi-v1.6.2.1.tar.bz2
CHANGELOG-1.6.2.1
1) Fixed iscsi_put_lun() to not include 0x4 at start of Flat Space
64-bit SCSI LUN Addressing (Wasabi+Netapp support added) that was
causing a 'logical unit not connected' execption in INQUIRY readback
data.
2) Only make noise when handling a Underflow mismatching between local
missing read data value and resid.
Index: iscsi_initiator_util.c
===================================================================
--- iscsi_initiator_util.c (revision 2146)
+++ iscsi_initiator_util.c (working copy)
@@ -1691,7 +1691,7 @@
u64 ret;
ret = ((lun & 0xff) << 8);
- ret |= 0x40 | ((lun >> 8) & 0x3f);
+ ret |= 0x00 | ((lun >> 8) & 0x3f);
return(cpu_to_le64(ret));
}
Index: iscsi_initiator.c
===================================================================
--- iscsi_initiator.c (revision 2146)
+++ iscsi_initiator.c (working copy)
@@ -2499,7 +2499,6 @@
TRACE_ERROR("Underflow Residual count %u
does"
" NOT match expected %d\n",
hdr->res_count,
missing);
- return(-1);
}
resid = hdr->res_count;
} else if (hdr->res_count != 0) {
--
Nicholas A. Bellinger <nab@kernel.org>
reply other threads:[~2005-12-06 19:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133897585.32388.5.camel@haakon \
--to=nab@kernel.org \
--cc=iscsitarget-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox