The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* core-iscsi v1.6.2.1 STABLE
@ 2005-12-06 19:33 Nicholas A. Bellinger
  0 siblings, 0 replies; only message in thread
From: Nicholas A. Bellinger @ 2005-12-06 19:33 UTC (permalink / raw)
  To: Open iSCSI, iet-dev, linux-scsi; +Cc: LKML

Greetings all!

Attached is a new release of the core-iscsi stack that solves one of the
items from RELEASE_NOTES (Netapp, Wasabi, SANRAD support) as well as a
additional fix related to iSCSI Underflow handling involving the removal
of a unnecessary 'return on error' condition.  A big thanks to Dominik
and Dustin @ VBI for making this release happen! 

These are both a single line change, please see the code below:

http://www.kernel.org/pub/linux/kernel/people/nab/iscsi-initiator-core/core-iscsi-v1.6.2.1.tar.bz2

CHANGELOG-1.6.2.1

1) Fixed iscsi_put_lun() to not include 0x4 at start of Flat Space
64-bit SCSI LUN Addressing (Wasabi+Netapp support added) that was
causing a 'logical unit not connected' execption in INQUIRY readback
data.
2) Only make noise when handling a Underflow mismatching between local
missing read data value and resid.

Index: iscsi_initiator_util.c
===================================================================
--- iscsi_initiator_util.c      (revision 2146)
+++ iscsi_initiator_util.c      (working copy)
@@ -1691,7 +1691,7 @@
        u64 ret;

        ret = ((lun & 0xff) << 8);
-       ret |= 0x40 | ((lun >> 8) & 0x3f);
+       ret |= 0x00 | ((lun >> 8) & 0x3f);

        return(cpu_to_le64(ret));
}
Index: iscsi_initiator.c
===================================================================
--- iscsi_initiator.c   (revision 2146)
+++ iscsi_initiator.c   (working copy)
@@ -2499,7 +2499,6 @@
                                TRACE_ERROR("Underflow Residual count %u
does"
                                        " NOT match expected %d\n",
                                                hdr->res_count,
missing);
-                               return(-1);
                        }
                        resid = hdr->res_count;
                } else if (hdr->res_count != 0) {




-- 
Nicholas A. Bellinger <nab@kernel.org>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-12-06 19:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-06 19:33 core-iscsi v1.6.2.1 STABLE Nicholas A. Bellinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox