[Patch] Overrun in

[Patch] Overrun in

[Eric Sesterhenn]

hi,

since the arrays are declared as in_urbs[N_IN_URB]
and out_urbs[N_OUT_URB] both for loops, go one
over the end of the array. This fixes coverity id #555

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>


--- linux-2.6.17-rc1/drivers/usb/serial/option.c.orig	2006-04-10 10:57:13.000000000 +0200
+++ linux-2.6.17-rc1/drivers/usb/serial/option.c	2006-04-10 10:57:46.000000000 +0200
@@ -582,14 +582,14 @@ static void option_setup_urbs(struct usb
 	portdata = usb_get_serial_port_data(port);
 
 	/* Do indat endpoints first */
-	for (j = 0; j <= N_IN_URB; ++j) {
+	for (j = 0; j < N_IN_URB; ++j) {
 		portdata->in_urbs[j] = option_setup_urb (serial,
                   port->bulk_in_endpointAddress, USB_DIR_IN, port,
                   portdata->in_buffer[j], IN_BUFLEN, option_indat_callback);
 	}
 
 	/* outdat endpoints */
-	for (j = 0; j <= N_OUT_URB; ++j) {
+	for (j = 0; j < N_OUT_URB; ++j) {
 		portdata->out_urbs[j] = option_setup_urb (serial,
                   port->bulk_out_endpointAddress, USB_DIR_OUT, port,
                   portdata->out_buffer[j], OUT_BUFLEN, option_outdat_callback);

Re: [Patch] Overrun in

[smurf]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hi,

Eric Sesterhenn:
> since the arrays are declared as in_urbs[N_IN_URB]
> and out_urbs[N_OUT_URB] both for loops, go one
> over the end of the array. This fixes coverity id #555
> 
Ouch. Thanks.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]