The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] tpm: fix memory leak
@ 2006-04-19 19:13 Kylene Jo Hall
  0 siblings, 0 replies; only message in thread
From: Kylene Jo Hall @ 2006-04-19 19:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, TPM Device Driver List

The eventname was kmalloc'd and not freed in the *_show functions.

This bug was found by Coverity.

Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
 drivers/char/tpm/tpm_bios.c |    2 ++
 1 files changed, 2 insertions(+)

--- linux-2.6.17-rc1/drivers/char/tpm/tpm_bios.c	2006-04-18 15:14:45.626390250 -0500
+++ linux-2.6.17-rc1-tpm/drivers/char/tpm/tpm_bios.c	2006-04-19 13:53:55.746954250 -0500
@@ -320,6 +321,7 @@ static int tpm_binary_bios_measurements_
 	/* 5th: delimiter */
 	seq_putc(m, '\0');
 
+	kfree(eventname);
 	return 0;
 }
 
@@ -367,6 +369,7 @@ static int tpm_ascii_bios_measurements_s
 	/* 4th: eventname <= max + \'0' delimiter */
 	seq_printf(m, " %s\n", eventname);
 
+	kfree(eventname);
 	return 0;
 }
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-19 19:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-19 19:13 [PATCH] tpm: fix memory leak Kylene Jo Hall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox