* [PATCH] video: fm2fb: constify zorro_device_id @ 2017-08-22 18:17 ` Arvind Yadav 2017-09-04 12:47 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Arvind Yadav @ 2017-08-22 18:17 UTC (permalink / raw) To: b.zolnierkie; +Cc: linux-kernel, linux-fbdev zorro_device_id are not supposed to change at runtime. All functions working with zorro_device_id provided by <linux/zorro.h> work with const zorro_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/video/fbdev/fm2fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/fm2fb.c b/drivers/video/fbdev/fm2fb.c index e69d47a..ac7a4eb 100644 --- a/drivers/video/fbdev/fm2fb.c +++ b/drivers/video/fbdev/fm2fb.c @@ -213,7 +213,7 @@ static int fm2fb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, static int fm2fb_probe(struct zorro_dev *z, const struct zorro_device_id *id); -static struct zorro_device_id fm2fb_devices[] = { +static const struct zorro_device_id fm2fb_devices[] = { { ZORRO_PROD_BSC_FRAMEMASTER_II }, { ZORRO_PROD_HELFRICH_RAINBOW_II }, { 0 } -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fm2fb: constify zorro_device_id 2017-08-22 18:17 ` [PATCH] video: fm2fb: constify zorro_device_id Arvind Yadav @ 2017-09-04 12:47 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-09-04 12:47 UTC (permalink / raw) To: Arvind Yadav; +Cc: linux-kernel, linux-fbdev On Tuesday, August 22, 2017 11:47:48 PM Arvind Yadav wrote: > zorro_device_id are not supposed to change at runtime. All functions > working with zorro_device_id provided by <linux/zorro.h> work with > const zorro_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-04 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170822181806epcas1p402a52d6fa3b22d5609d2b1ffe9d1f080@epcas1p4.samsung.com>
2017-08-22 18:17 ` [PATCH] video: fm2fb: constify zorro_device_id Arvind Yadav
2017-09-04 12:47 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox