From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: 박경민 <kyungmin.park@samsung.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor()
Date: Wed, 21 Nov 2012 10:18:44 +0000 (GMT) [thread overview]
Message-ID: <11617564.20991353493124275.JavaMail.weblogic@epml17> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1086 bytes --]
> Use the value obtained from the function instead of -EINVAL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Both patches applied as they are obvious bugfixes.
I'll send pull request with other bugfixes within days.
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 83c2129..2bd9ab0 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -644,7 +644,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
> if (IS_ERR(g)) {
> pr_err("%s: governor %s not registered\n", __func__,
> governor->name);
> - err = -EINVAL;
> + err = PTR_ERR(g);
> goto err_out;
> }
> list_for_each_entry(devfreq, &devfreq_list, node) {
> --
> 1.7.4.1
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2012-11-21 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 10:18 MyungJoo Ham [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 5:06 [PATCH 1/2] PM/devfreq: Fix incorrect argument in error message Sachin Kamat
2012-11-21 5:06 ` [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor() Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11617564.20991353493124275.JavaMail.weblogic@epml17 \
--to=myungjoo.ham@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox