* [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor()
2012-11-21 5:06 [PATCH 1/2] PM/devfreq: Fix incorrect argument in error message Sachin Kamat
@ 2012-11-21 5:06 ` Sachin Kamat
0 siblings, 0 replies; 2+ messages in thread
From: Sachin Kamat @ 2012-11-21 5:06 UTC (permalink / raw)
To: linux-kernel; +Cc: myungjoo.ham, kyungmin.park, sachin.kamat, patches
Use the value obtained from the function instead of -EINVAL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/devfreq/devfreq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 83c2129..2bd9ab0 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -644,7 +644,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
if (IS_ERR(g)) {
pr_err("%s: governor %s not registered\n", __func__,
governor->name);
- err = -EINVAL;
+ err = PTR_ERR(g);
goto err_out;
}
list_for_each_entry(devfreq, &devfreq_list, node) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor()
@ 2012-11-21 10:18 MyungJoo Ham
0 siblings, 0 replies; 2+ messages in thread
From: MyungJoo Ham @ 2012-11-21 10:18 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel@vger.kernel.org
Cc: 박경민, patches@linaro.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1086 bytes --]
> Use the value obtained from the function instead of -EINVAL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Both patches applied as they are obvious bugfixes.
I'll send pull request with other bugfixes within days.
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 83c2129..2bd9ab0 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -644,7 +644,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
> if (IS_ERR(g)) {
> pr_err("%s: governor %s not registered\n", __func__,
> governor->name);
> - err = -EINVAL;
> + err = PTR_ERR(g);
> goto err_out;
> }
> list_for_each_entry(devfreq, &devfreq_list, node) {
> --
> 1.7.4.1
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-21 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 10:18 [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor() MyungJoo Ham
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 5:06 [PATCH 1/2] PM/devfreq: Fix incorrect argument in error message Sachin Kamat
2012-11-21 5:06 ` [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove_governor() Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox