From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -rt][RESEND] spin lock imbalance in ibm emac
Date: Mon, 11 Dec 2006 08:05:17 -0800 [thread overview]
Message-ID: <1165853117.7764.5.camel@imap.mvista.com> (raw)
In-Reply-To: <20061211155908.GA31944@elte.hu>
On Mon, 2006-12-11 at 16:59 +0100, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > On Mon, 2006-12-11 at 10:27 +0100, Ingo Molnar wrote:
> > > * Daniel Walker <dwalker@mvista.com> wrote:
> > >
> > > > Sent this a long time ago, still exists.
> > > >
> > > > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> > >
> > > hm, what does this do, and why isnt it upstream?
> >
> > AFAIK, those locks are added in -rt . I'm not sure how they got in
> > there, but they fix that driver when running in a thread. The driver
> > has unsafe SMP locking, but the only system it runs on (PPC4xx) is
> > uniprocessor. So it's not broken upstream per se.
>
> ok, i've applied your patch.
What about the OMAP fix? that one's been sitting around for a while too.
Daniel
prev parent reply other threads:[~2006-12-11 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 16:38 [PATCH -rt][RESEND] spin lock imbalance in ibm emac Daniel Walker
2006-12-11 9:27 ` Ingo Molnar
2006-12-11 15:40 ` Daniel Walker
2006-12-11 15:59 ` Ingo Molnar
2006-12-11 16:05 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165853117.7764.5.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox