From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>, Jeff Garzik <jeff@garzik.org>,
Christoph Hellwig <hch@infradead.org>,
Pekka J Enberg <penberg@cs.helsinki.fi>
Subject: [PATCH 0/5] lguest feedback tidyups
Date: Fri, 11 May 2007 11:17:26 +1000 [thread overview]
Message-ID: <1178846246.23513.21.camel@localhost.localdomain> (raw)
Hi all,
Gratefully-received recent feedback from CC'd was applied to excellent
effect (and the advice from Matt Mackall about my personal appearance is
best unrequited).
The patch is split in 5 parts to correspond with the 9 parts Andrew
sent out before, but here's the summary:
1) Sparse (thanks Christoph Hellwig):
- lguest_const can be static now
- lguest.c should include "lguest_bus.h" for lguest_devices declaration.
- page_tables.c unnecessary initialization
- But the cost was high: lots of __force casts 8(
2) Jeff Garzik
- Use netdev_priv instead of dev->priv.
- Check for ioremap failure
- iounmap on failure.
- Wrap SEND_DMA and BIND_DMA calls
- Don't set NETIF_F_SG unless we set NETIF_F_NO_CSUM
- Use SET_NETDEV_DEV()
- Don't set dev->irq, mem_start & mem_end (deprecated)
3) Sam Ravnborg
- lg-objs is deprecated, use lg-y.
Cheers,
Rusty.
next reply other threads:[~2007-05-11 1:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 1:17 Rusty Russell [this message]
2007-05-11 1:19 ` [PATCH 1/5] lguest host feedback tidyups Rusty Russell
2007-05-11 1:21 ` [PATCH 2/5] lguest guest " Rusty Russell
2007-05-11 1:22 ` [PATCH 3/5] lguest network driver " Rusty Russell
2007-05-11 1:23 ` [PATCH 4/5] lguest block " Rusty Russell
2007-05-11 1:24 ` [PATCH 5/5] lguest console " Rusty Russell
2007-05-13 4:08 ` [PATCH 4/5] lguest block " Rusty Russell
2007-05-13 3:52 ` [PATCH 3/5] lguest network " Rusty Russell
2007-05-13 4:12 ` Rusty Russell
2007-05-11 6:56 ` [PATCH 2/5] lguest guest " Christoph Hellwig
2007-05-11 7:31 ` Rusty Russell
2007-05-11 7:40 ` Christoph Hellwig
2007-05-13 1:00 ` Rusty Russell
2007-05-13 3:48 ` Rusty Russell
2007-05-13 18:43 ` Al Viro
2007-05-14 7:11 ` Rusty Russell
2007-05-13 4:07 ` [PATCH 1/5] lguest host " Rusty Russell
2007-05-13 18:47 ` Al Viro
2007-05-14 1:30 ` Rusty Russell
2007-05-13 18:39 ` Al Viro
2007-05-14 1:44 ` Rusty Russell
2007-05-14 5:38 ` Rusty Russell
2007-05-11 6:53 ` [PATCH 0/5] lguest " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178846246.23513.21.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sam@ravnborg.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox