public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Jeff Garzik <jeff@garzik.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/5] lguest guest feedback tidyups
Date: Mon, 14 May 2007 17:11:49 +1000	[thread overview]
Message-ID: <1179126709.23513.194.camel@localhost.localdomain> (raw)
In-Reply-To: <20070513184339.GZ4095@ftp.linux.org.uk>

On Sun, 2007-05-13 at 19:43 +0100, Al Viro wrote:
> On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote:
> >  	/* Devices are in page above top of "normal" mem. */
> > -	lguest_devices = ioremap(max_pfn << PAGE_SHIFT, PAGE_SIZE);
> > +	lguest_devices = (__force void*)ioremap(max_pfn<<PAGE_SHIFT,PAGE_SIZE);
> 
> Er...  What's being done here?  What are we mapping and what's going to
> be accessed when we dereference that sucker?

This, too, is now wrapped in lguest_map() in the updated patch.  

Guest virtual device memory can be directly accessed, but Jeff Garzik
and Christoph Hellwig made good points about not encouraging such
abnormal use of ioremap in drivers.

BTW, I've done a new rollup patch of lguest against 2.6.21, if you would
like to review the whole thing.  This version includes the big code
documentation patch not yet in -mm.

	http://lguest.ozlabs.org/lguest-2.6.21-290.patch.gz

Thanks,
Rusty.


  reply	other threads:[~2007-05-14  7:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  1:17 [PATCH 0/5] lguest feedback tidyups Rusty Russell
2007-05-11  1:19 ` [PATCH 1/5] lguest host " Rusty Russell
2007-05-11  1:21   ` [PATCH 2/5] lguest guest " Rusty Russell
2007-05-11  1:22     ` [PATCH 3/5] lguest network driver " Rusty Russell
2007-05-11  1:23       ` [PATCH 4/5] lguest block " Rusty Russell
2007-05-11  1:24         ` [PATCH 5/5] lguest console " Rusty Russell
2007-05-13  4:08         ` [PATCH 4/5] lguest block " Rusty Russell
2007-05-13  3:52       ` [PATCH 3/5] lguest network " Rusty Russell
2007-05-13  4:12         ` Rusty Russell
2007-05-11  6:56     ` [PATCH 2/5] lguest guest " Christoph Hellwig
2007-05-11  7:31       ` Rusty Russell
2007-05-11  7:40         ` Christoph Hellwig
2007-05-13  1:00           ` Rusty Russell
2007-05-13  3:48       ` Rusty Russell
2007-05-13 18:43     ` Al Viro
2007-05-14  7:11       ` Rusty Russell [this message]
2007-05-13  4:07   ` [PATCH 1/5] lguest host " Rusty Russell
2007-05-13 18:47     ` Al Viro
2007-05-14  1:30       ` Rusty Russell
2007-05-13 18:39   ` Al Viro
2007-05-14  1:44     ` Rusty Russell
2007-05-14  5:38       ` Rusty Russell
2007-05-11  6:53 ` [PATCH 0/5] lguest " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179126709.23513.194.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox