public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] -rt fix TSC calibration from PM Timer
@ 2007-05-21 15:43 Joachim Deguara
  2007-05-21 16:01 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Joachim Deguara @ 2007-05-21 15:43 UTC (permalink / raw)
  To: LKML, Ingo Molnar, Thomas Gleixner

The code to calibrate TSC frequency from the PM timer does not work on my 
laptop with the 2.6.21-rt5.

[    0.247815] time.c: Detected 62117.606 MHz processor.

The code looks to be copied from the calibration from HPET but unfortunately 
it reports frequency instead of period in femtoseconds as the HPET does.  I 
also rearranged the math to make the femtoseconds and kHz clearer but it does 
loose a negligible amount of precision.

Signed-off-by: Joachim Deguara <joachim.deguara@amd.com>

Index: 2.6-rt/arch/x86_64/kernel/tsc.c
===================================================================
--- 2.6-rt.orig/arch/x86_64/kernel/tsc.c
+++ 2.6-rt/arch/x86_64/kernel/tsc.c
@@ -187,14 +187,14 @@ void __init tsc_calibrate(void)
 		return;
 	}
 
-	tsc2 = (tsc2 - tsc1) * 1000000000L;
+	tsc2 = tsc2 - tsc1;
 
 	if (hpet) {
 		hpet2 = (hpet2 - hpet1) & 0xFFFFFFFF;
-		tsc1 = (hpet2 * hpet_readl(HPET_PERIOD)) / 1000;
+		tsc1 = hpet2 * hpet_readl(HPET_PERIOD) / 1e12;
 	} else {
 		pm2 = (pm2 -pm1) & ACPI_PM_MASK;
-		tsc1 = (pm2 * PMTMR_TICKS_PER_SEC) / 1000;
+		tsc1 = (pm2 * 1e3) / PMTMR_TICKS_PER_SEC;
 	}
 
 	tsc_khz = tsc2 / tsc1;



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] -rt fix TSC calibration from PM Timer
  2007-05-21 15:43 [PATCH] -rt fix TSC calibration from PM Timer Joachim Deguara
@ 2007-05-21 16:01 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2007-05-21 16:01 UTC (permalink / raw)
  To: Joachim Deguara; +Cc: LKML, Ingo Molnar

On Mon, 2007-05-21 at 17:43 +0200, Joachim Deguara wrote:
> The code to calibrate TSC frequency from the PM timer does not work on my 
> laptop with the 2.6.21-rt5.
> 
> [    0.247815] time.c: Detected 62117.606 MHz processor.

I know. The code was fixed in the x86_64-hrt queue, but never moved to
-rt. The sync to -hrt is already in the -rt6 pipeline.

	tglx


	


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-21 15:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-21 15:43 [PATCH] -rt fix TSC calibration from PM Timer Joachim Deguara
2007-05-21 16:01 ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox