From: Matthew Helsley <matthltc@us.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Bill Huey <billh@gnuppy.monkey.org>,
Jason Baron <jbaron@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 5/6] lockstat: human readability tweaks
Date: Wed, 30 May 2007 12:39:05 -0700 [thread overview]
Message-ID: <1180553945.4738.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20070530125336.322824180@chello.nl>
On Wed, 2007-05-30 at 14:49 +0200, Peter Zijlstra wrote:
> plain text document attachment (lockstat-output.patch)
> Present all this fancy new lock statistics information:
>
> *warning, _wide_ output ahead*
>
> (output edited for purpose of brevity)
>
> # cat /proc/lock_stat
> lock_stat version 0.1
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> class name contentions waittime-min waittime-max waittime-total acquisitions holdtime-min holdtime-max holdtime-total
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
<snip>
> 'contentions' and 'acquisitions' are the number of such events measured (since
> the last reset). The waittime- and holdtime- (min, max, total) numbers are
> presented in microseconds.
I think it would make sense to actually mention the time scale in the
output header someplace. Then a tool written to analyze this file will
have a way of determining the time scale without using error-prone
heuristics (like "kernel version foo uses microseconds while kernel foo
+ 100 uses nanoseconds").
<snip>
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2007-05-30 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 12:49 [PATCH 0/6] lock contention tracking -v4 Peter Zijlstra
2007-05-30 12:49 ` [PATCH 1/6] fix raw_spinlock_t vs lockdep Peter Zijlstra
2007-05-30 12:49 ` [PATCH 2/6] lockdep: sanitise CONFIG_PROVE_LOCKING Peter Zijlstra
2007-05-30 12:49 ` [PATCH 3/6] lockdep: reduce the ifdeffery Peter Zijlstra
2007-05-30 12:49 ` [PATCH 4/6] lockstat: core infrastructure Peter Zijlstra
2007-05-30 12:49 ` [PATCH 5/6] lockstat: human readability tweaks Peter Zijlstra
2007-05-30 19:39 ` Matthew Helsley [this message]
2007-05-31 9:17 ` Peter Zijlstra
2007-05-30 12:49 ` [PATCH 6/6] lockstat: hook into spinlock_t, rwlock_t, rwsem and mutex Peter Zijlstra
2007-05-30 13:17 ` [PATCH 0/6] lock contention tracking -v4 Ingo Molnar
2007-05-30 17:40 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180553945.4738.13.camel@localhost.localdomain \
--to=matthltc@us.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=billh@gnuppy.monkey.org \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox