From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Bill Huey <billh@gnuppy.monkey.org>,
Jason Baron <jbaron@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 0/6] lock contention tracking -v4
Date: Wed, 30 May 2007 15:17:51 +0200 [thread overview]
Message-ID: <20070530131751.GA22724@elte.hu> (raw)
In-Reply-To: <20070530124903.882133089@chello.nl>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Changes since -v3
> - reshuffled code to reduce #ifdef mess
| Now at patch patches/raw_spinlock_fix.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 17
ok, this is unmodified lockdep.c.
| # quilt push
| Applying patch patches/lockdep-prove-locking.patch
| patching file kernel/lockdep.c
| patching file kernel/spinlock.c
|
| Now at patch patches/lockdep-prove-locking.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 23
this was the increase that Christoph commented on.
| # quilt push
| Applying patch patches/lockdep-reduce-ifdefs.patch
| patching file kernel/lockdep.c
| patching file kernel/lockdep_proc.c
|
| Now at patch patches/lockdep-reduce-ifdefs.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 11
and now it's lower than where it started out and you also put lockstat
in! Nice! :)
Ingo
next prev parent reply other threads:[~2007-05-30 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 12:49 [PATCH 0/6] lock contention tracking -v4 Peter Zijlstra
2007-05-30 12:49 ` [PATCH 1/6] fix raw_spinlock_t vs lockdep Peter Zijlstra
2007-05-30 12:49 ` [PATCH 2/6] lockdep: sanitise CONFIG_PROVE_LOCKING Peter Zijlstra
2007-05-30 12:49 ` [PATCH 3/6] lockdep: reduce the ifdeffery Peter Zijlstra
2007-05-30 12:49 ` [PATCH 4/6] lockstat: core infrastructure Peter Zijlstra
2007-05-30 12:49 ` [PATCH 5/6] lockstat: human readability tweaks Peter Zijlstra
2007-05-30 19:39 ` Matthew Helsley
2007-05-31 9:17 ` Peter Zijlstra
2007-05-30 12:49 ` [PATCH 6/6] lockstat: hook into spinlock_t, rwlock_t, rwsem and mutex Peter Zijlstra
2007-05-30 13:17 ` Ingo Molnar [this message]
2007-05-30 17:40 ` [PATCH 0/6] lock contention tracking -v4 Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530131751.GA22724@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=billh@gnuppy.monkey.org \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox