From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] neaten lguest boot code (again)
Date: Wed, 06 Jun 2007 12:37:39 +1000 [thread overview]
Message-ID: <1181097459.14054.100.camel@localhost.localdomain> (raw)
(This cleanup seems to have gotten lost in rc3-mm1? It was in rc2-mm1
called lguest-the-host-code-update-for-mm-simplify-boot_params.patch)
Andrew patched up lguest after the boot parameters became a proper
structure, but in fact it can be considerably neatened.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/lguest/lguest.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
===================================================================
--- a/drivers/lguest/lguest.c
+++ b/drivers/lguest/lguest.c
@@ -444,8 +444,7 @@ __init void lguest_init(void *boot)
{
/* Copy boot parameters first. */
memcpy(&boot_params, boot, PARAM_SIZE);
- memcpy(boot_command_line,
- __va(*(unsigned long *)((void *)&boot_params + NEW_CL_POINTER)),
+ memcpy(boot_command_line, __va(boot_params.hdr.cmd_line_ptr),
COMMAND_LINE_SIZE);
paravirt_ops.name = "lguest";
next reply other threads:[~2007-06-06 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 2:37 Rusty Russell [this message]
2007-06-06 2:48 ` [PATCH] neaten lguest boot code (again) Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181097459.14054.100.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox