* [PATCH] neaten lguest boot code (again)
@ 2007-06-06 2:37 Rusty Russell
2007-06-06 2:48 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2007-06-06 2:37 UTC (permalink / raw)
To: Andrew Morton
Cc: H. Peter Anvin, Eric W. Biederman, lkml - Kernel Mailing List
(This cleanup seems to have gotten lost in rc3-mm1? It was in rc2-mm1
called lguest-the-host-code-update-for-mm-simplify-boot_params.patch)
Andrew patched up lguest after the boot parameters became a proper
structure, but in fact it can be considerably neatened.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/lguest/lguest.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
===================================================================
--- a/drivers/lguest/lguest.c
+++ b/drivers/lguest/lguest.c
@@ -444,8 +444,7 @@ __init void lguest_init(void *boot)
{
/* Copy boot parameters first. */
memcpy(&boot_params, boot, PARAM_SIZE);
- memcpy(boot_command_line,
- __va(*(unsigned long *)((void *)&boot_params + NEW_CL_POINTER)),
+ memcpy(boot_command_line, __va(boot_params.hdr.cmd_line_ptr),
COMMAND_LINE_SIZE);
paravirt_ops.name = "lguest";
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] neaten lguest boot code (again)
2007-06-06 2:37 [PATCH] neaten lguest boot code (again) Rusty Russell
@ 2007-06-06 2:48 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2007-06-06 2:48 UTC (permalink / raw)
To: Rusty Russell
Cc: H. Peter Anvin, Eric W. Biederman, lkml - Kernel Mailing List
On Wed, 06 Jun 2007 12:37:39 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote:
> (This cleanup seems to have gotten lost in rc3-mm1? It was in rc2-mm1
> called lguest-the-host-code-update-for-mm-simplify-boot_params.patch)
>
> Andrew patched up lguest after the boot parameters became a proper
> structure, but in fact it can be considerably neatened.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/lguest/lguest.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> ===================================================================
> --- a/drivers/lguest/lguest.c
> +++ b/drivers/lguest/lguest.c
> @@ -444,8 +444,7 @@ __init void lguest_init(void *boot)
> {
> /* Copy boot parameters first. */
> memcpy(&boot_params, boot, PARAM_SIZE);
> - memcpy(boot_command_line,
> - __va(*(unsigned long *)((void *)&boot_params + NEW_CL_POINTER)),
> + memcpy(boot_command_line, __va(boot_params.hdr.cmd_line_ptr),
> COMMAND_LINE_SIZE);
>
> paravirt_ops.name = "lguest";
I dropped it because it depended upon mm-simplify-boot_params.patch which
for some reason disappeared but now appears to have reappeared.
Shall resurrect.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-06 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-06 2:37 [PATCH] neaten lguest boot code (again) Rusty Russell
2007-06-06 2:48 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox