* [PATCH RT] Only check IRQ Thread affinity update if CPU affinity changed.
@ 2007-06-19 19:41 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2007-06-19 19:41 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, LKML, RT
This patch cleans up the softirq in hardirq change. The hard irq threads
pin themselves to one of the CPUs that the IRQ affinity is on.
This patch cleans up this by only updating the cpu affinity, if the cpu
that the thread is pinned on is no longer part of the IRQ affinity.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6-rt-test/kernel/irq/manage.c
===================================================================
--- linux-2.6-rt-test.orig/kernel/irq/manage.c
+++ linux-2.6-rt-test/kernel/irq/manage.c
@@ -762,13 +762,15 @@ static int do_irqd(void * __desc)
#ifdef CONFIG_SMP
cpumask_t cpus_allowed, mask;
+ int pinned_cpu;
cpus_allowed = desc->affinity;
/*
* Restrict it to one cpu so we avoid being migrated inside of
* do_softirq_from_hardirq()
*/
- mask = cpumask_of_cpu(first_cpu(desc->affinity));
+ pinned_cpu = first_cpu(desc->affinity);
+ mask = cpumask_of_cpu(pinned_cpu);
set_cpus_allowed(current, mask);
#endif
current->flags |= PF_NOFREEZE | PF_HARDIRQ;
@@ -793,14 +795,15 @@ static int do_irqd(void * __desc)
/*
* Did IRQ affinities change?
*/
- if (!cpus_equal(cpus_allowed, desc->affinity)) {
+ if (!cpu_isset(pinned_cpu, desc->affinity)) {
cpus_allowed = desc->affinity;
/*
* Restrict it to one cpu so we avoid being
* migrated inside of
* do_softirq_from_hardirq()
*/
- mask = cpumask_of_cpu(first_cpu(desc->affinity));
+ pinned_cpu = first_cpu(desc->affinity);
+ mask = cpumask_of_cpu(pinned_cpu);
set_cpus_allowed(current, mask);
}
#endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-06-19 19:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-19 19:41 [PATCH RT] Only check IRQ Thread affinity update if CPU affinity changed Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox