The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Oleg Nesterov <oleg@tv-sign.ru>,
	Arjan van de Ven <arjan@infradead.org>,
	Thomas Sattler <tsattler@gmx.de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep
Date: Thu, 05 Jul 2007 11:03:24 +0200	[thread overview]
Message-ID: <1183626204.7054.58.camel@twins> (raw)
In-Reply-To: <1183583529.9662.34.camel@johannes.berg>

On Wed, 2007-07-04 at 23:12 +0200, Johannes Berg wrote:
> This adds a lockdep_map for each work struct in order to debug
> deadlocks like
>   my_function -> lock(); ...; cancel_work_sync(my_work)
> vs.
>   run_workqueue() -> my_work.f() -> ...; lock(); ...
> 
> which will deadlock if my_work.f() is invoked already but my_function()
> has acquired the lock already.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>


      parent reply	other threads:[~2007-07-05  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04 21:12 [PATCH] debug work struct cancel deadlocks with lockdep Johannes Berg
2007-07-05  8:45 ` Ingo Molnar
2007-07-05  8:50   ` Johannes Berg
2007-07-05  8:54     ` Ingo Molnar
2007-07-05  8:53 ` Ingo Molnar
2007-07-05  8:58   ` Johannes Berg
2007-07-05  9:01     ` Peter Zijlstra
2007-07-05  9:08       ` Johannes Berg
2007-07-05  9:10         ` Peter Zijlstra
2007-07-05  9:19           ` Johannes Berg
2007-07-05  9:03 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1183626204.7054.58.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=arjan@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=tsattler@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox