From: Ingo Molnar <mingo@elte.hu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
Arjan van de Ven <arjan@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Sattler <tsattler@gmx.de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep
Date: Thu, 5 Jul 2007 10:45:38 +0200 [thread overview]
Message-ID: <20070705084538.GA3476@elte.hu> (raw)
In-Reply-To: <1183583529.9662.34.camel@johannes.berg>
* Johannes Berg <johannes@sipsolutions.net> wrote:
> +#ifdef CONFIG_LOCKDEP
> + /*
> + * It is permissible to free the struct work_struct
> + * from inside the function that is called from it,
> + * this we need to take into account for lockdep too.
> + * To avoid bogus "held lock freed" warnings as well
> + * as problems when looking into work->lockdep_map,
> + * make a copy and use that here.
> + */
> + struct lockdep_map lockdep_map = work->lockdep_map;
> +#endif
> + lock_acquire(&lockdep_map, 0, 0, 0, 2, _THIS_IP_);
> f(work);
> + lock_release(&lockdep_map, 1, _THIS_IP_);
neat trick :)
Ingo
next prev parent reply other threads:[~2007-07-05 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 21:12 [PATCH] debug work struct cancel deadlocks with lockdep Johannes Berg
2007-07-05 8:45 ` Ingo Molnar [this message]
2007-07-05 8:50 ` Johannes Berg
2007-07-05 8:54 ` Ingo Molnar
2007-07-05 8:53 ` Ingo Molnar
2007-07-05 8:58 ` Johannes Berg
2007-07-05 9:01 ` Peter Zijlstra
2007-07-05 9:08 ` Johannes Berg
2007-07-05 9:10 ` Peter Zijlstra
2007-07-05 9:19 ` Johannes Berg
2007-07-05 9:03 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705084538.GA3476@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=tsattler@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox