The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH RT] don't BUG_ON in exit for in_interrupt
@ 2007-07-06 13:19 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2007-07-06 13:19 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Thomas Gleixner, LKML, RT

For some reason, in the RT kernel, we have in exit.c a
BUG_ON(in_interrupt()) just before a check of in_interrupt() then panic.
With the panic, we get a nice output of what happened (considering that
the panic gives us a backtrace).

But a BUG_ON will cause a fault, and then try to bug again. This causes
a recursive fault which eventually eats up the stack.  Twice have we
lost information on a crash because of this recursive faulting.

This patch undoes the adding the BUG_ON in exit.c.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.21.5-rt17/kernel/exit.c
===================================================================
--- linux-2.6.21.5-rt17.orig/kernel/exit.c
+++ linux-2.6.21.5-rt17/kernel/exit.c
@@ -863,7 +863,6 @@ fastcall NORET_TYPE void do_exit(long co
 
 	WARN_ON(atomic_read(&tsk->fs_excl));
 
-	BUG_ON(in_interrupt());
 	if (unlikely(in_interrupt()))
 		panic("Aiee, killing interrupt handler!");
 	if (unlikely(!tsk->pid))



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-06 13:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-06 13:19 [PATCH RT] don't BUG_ON in exit for in_interrupt Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox