From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andi Kleen <ak@suse.de>
Subject: [PATCH] i386: flush_cpumask doesn't need "or"
Date: Tue, 31 Jul 2007 15:59:42 +1000 [thread overview]
Message-ID: <1185861582.5495.424.camel@localhost.localdomain> (raw)
Did I miss something or do we needlessly do an "or" to flush_cpumask
while we could just assign it ? We never exit that function with the
mask not empty and we have a spinlock...
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/arch/i386/kernel/smp.c
===================================================================
--- linux-work.orig/arch/i386/kernel/smp.c 2007-07-31 15:54:55.000000000 +1000
+++ linux-work/arch/i386/kernel/smp.c 2007-07-31 15:56:13.000000000 +1000
@@ -375,7 +375,8 @@ void native_flush_tlb_others(const cpuma
flush_mm = mm;
flush_va = va;
- cpus_or(flush_cpumask, cpumask, flush_cpumask);
+ flush_cpumask = cpumask;
+
/*
* We have to send the IPI only to
* CPUs affected.
reply other threads:[~2007-07-31 6:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185861582.5495.424.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox