* [PATCH] i386: flush_cpumask doesn't need "or"
@ 2007-07-31 5:59 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2007-07-31 5:59 UTC (permalink / raw)
To: Linux Kernel list; +Cc: Linus Torvalds, Andi Kleen
Did I miss something or do we needlessly do an "or" to flush_cpumask
while we could just assign it ? We never exit that function with the
mask not empty and we have a spinlock...
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/arch/i386/kernel/smp.c
===================================================================
--- linux-work.orig/arch/i386/kernel/smp.c 2007-07-31 15:54:55.000000000 +1000
+++ linux-work/arch/i386/kernel/smp.c 2007-07-31 15:56:13.000000000 +1000
@@ -375,7 +375,8 @@ void native_flush_tlb_others(const cpuma
flush_mm = mm;
flush_va = va;
- cpus_or(flush_cpumask, cpumask, flush_cpumask);
+ flush_cpumask = cpumask;
+
/*
* We have to send the IPI only to
* CPUs affected.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-31 6:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-31 5:59 [PATCH] i386: flush_cpumask doesn't need "or" Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox