From: Thomas Renninger <trenn@suse.de>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: hmh@hmh.eng.br, linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thinkpad acpi module_exit fix
Date: Wed, 08 Aug 2007 11:48:40 +0200 [thread overview]
Message-ID: <1186566520.8780.140.camel@queen.suse.de> (raw)
In-Reply-To: <20070808164334.GA2732@darkstar.te-china.tietoenator.com>
On Wed, 2007-08-08 at 16:43 +0000, Dave Young wrote:
> Hi,
>
> [This fix is not very good for the global variable, any comments are
> welcome.]
>
> The thinkpad_acpi module_init fail out entrace is not very properly. if
> failing before register driver or before create sysfs file, the
> module_exit will try to remove nonexist sysfs files, the kernel will
> oops.
This one is already fixed in Len's git tree in the test branch and will
get merged to Linus soon (commit id:
ac36393de6034be7266264a435360e7628849005).
The (similar) patch got posted on linux-acpi with subject:
[PATCH 05/12] ACPI: thinkpad-acpi: fix the module init failure path
(Fri, 3 Aug 2007 18:33:38)
Thomas
next prev parent reply other threads:[~2007-08-08 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 16:43 [PATCH] thinkpad acpi module_exit fix Dave Young
2007-08-08 9:48 ` Thomas Renninger [this message]
2007-08-08 12:16 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186566520.8780.140.camel@queen.suse.de \
--to=trenn@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox