From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thinkpad acpi module_exit fix
Date: Wed, 8 Aug 2007 09:16:03 -0300 [thread overview]
Message-ID: <20070808121603.GC554@khazad-dum.debian.net> (raw)
In-Reply-To: <20070808164334.GA2732@darkstar.te-china.tietoenator.com>
On Wed, 08 Aug 2007, Dave Young wrote:
> [This fix is not very good for the global variable, any comments are
> welcome.]
>
> The thinkpad_acpi module_init fail out entrace is not very properly. if
> failing before register driver or before create sysfs file, the
> module_exit will try to remove nonexist sysfs files, the kernel will
> oops.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
NAK, this is already fixed in Len's tree.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2007-08-08 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 16:43 [PATCH] thinkpad acpi module_exit fix Dave Young
2007-08-08 9:48 ` Thomas Renninger
2007-08-08 12:16 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808121603.GC554@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=hidave.darkstar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox