* [PATCH] gfs2: better code for translating characters
@ 2007-08-13 3:01 Denis Cheng
2007-08-13 3:08 ` rae l
0 siblings, 1 reply; 3+ messages in thread
From: Denis Cheng @ 2007-08-13 3:01 UTC (permalink / raw)
To: Steven Whitehouse; +Cc: cluster-devel, linux-kernel
the original code could work, but I think this code could work better.
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
fs/gfs2/ops_fstype.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index cf5aa50..b9a7759 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -145,7 +145,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);
- while ((table = strchr(sdp->sd_table_name, '/')))
+ table = sdp->sd_table_name;
+ while ((table = strchr(table, '/')))
*table = '_';
out:
--
1.5.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gfs2: better code for translating characters
2007-08-13 3:01 [PATCH] gfs2: better code for translating characters Denis Cheng
@ 2007-08-13 3:08 ` rae l
2007-08-13 4:27 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: rae l @ 2007-08-13 3:08 UTC (permalink / raw)
To: Steven Whitehouse; +Cc: cluster-devel, linux-kernel
On 8/13/07, Denis Cheng <crquan@gmail.com> wrote:
> the original code could work, but I think this code could work better.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> fs/gfs2/ops_fstype.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index cf5aa50..b9a7759 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -145,7 +145,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
> snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
> snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);
>
> - while ((table = strchr(sdp->sd_table_name, '/')))
> + table = sdp->sd_table_name;
> + while ((table = strchr(table, '/')))
> *table = '_';
Sorry, I don't know what the while loop really means, what's the
common case that slash character exists? if the '/' appears multiple,
the latter code would be better; however, if slash appears rarely, the
original would still be better.
>
> out:
> --
> 1.5.2.2
>
>
--
Denis Cheng
Linux Application Developer
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gfs2: better code for translating characters
2007-08-13 3:08 ` rae l
@ 2007-08-13 4:27 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2007-08-13 4:27 UTC (permalink / raw)
To: rae l; +Cc: Steven Whitehouse, cluster-devel, linux-kernel
rae l wrote:
> On 8/13/07, Denis Cheng <crquan@gmail.com> wrote:
>> the original code could work, but I think this code could work better.
>>
>> Signed-off-by: Denis Cheng <crquan@gmail.com>
>> ---
>> fs/gfs2/ops_fstype.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
>> index cf5aa50..b9a7759 100644
>> --- a/fs/gfs2/ops_fstype.c
>> +++ b/fs/gfs2/ops_fstype.c
>> @@ -145,7 +145,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
>> snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
>> snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);
>>
>> - while ((table = strchr(sdp->sd_table_name, '/')))
>> + table = sdp->sd_table_name;
>> + while ((table = strchr(table, '/')))
>> *table = '_';
> Sorry, I don't know what the while loop really means, what's the
> common case that slash character exists? if the '/' appears multiple,
> the latter code would be better; however, if slash appears rarely, the
> original would still be better.
>
Only if the compiler is stupid.
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-13 4:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-13 3:01 [PATCH] gfs2: better code for translating characters Denis Cheng
2007-08-13 3:08 ` rae l
2007-08-13 4:27 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox