convert #include "linux/..." to #include <linux/...> [PATCH]s follow

convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Joe Perches]

There are several files that:

#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>

Here's a little script that converts them:

egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'

Maybe a similar check could be added to checkpatch.pl

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Jesper Juhl]

On 20/08/07, Joe Perches <joe@perches.com> wrote:
> There are several files that:
>
> #include "linux/file" not #include <linux/file>
> #include "asm/file" not #include <asm/file>
>
> Here's a little script that converts them:
>
If you've actually checked that such conversions are correct and work
fine, how about a patch (or patches)?

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Jan Engelhardt]

On Aug 19 2007 15:17, Joe Perches wrote:
>There are several files that:
>
>#include "linux/file" not #include <linux/file>
>#include "asm/file" not #include <asm/file>

Not only that. All directories in include should be checked against
(e.g. <net/*>)


	Jan
-- 

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Al Viro]

On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote:
> 
> On Aug 19 2007 15:17, Joe Perches wrote:
> >There are several files that:
> >
> >#include "linux/file" not #include <linux/file>
> >#include "asm/file" not #include <asm/file>
> 
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)

Except that some instances are legitimate (e.g. there was a bunch in
arch/um, IIRC)...

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Joe Perches]

On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> Except that some instances are legitimate (e.g. there was a bunch in
> arch/um, IIRC)...

I guess it's a good thing that vger seems to have rejected
that 140KB patch I sent against arch/um and include/asm-um.

cheers, Joe

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Al Viro]

On Sun, Aug 19, 2007 at 03:49:16PM -0700, Joe Perches wrote:
> On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> > Except that some instances are legitimate (e.g. there was a bunch in
> > arch/um, IIRC)...
> 
> I guess it's a good thing that vger seems to have rejected
> that 140KB patch I sent against arch/um and include/asm-um.

It would be a better thing if you
	* did builds of the patched trees (allmodconfig for uml/i386 and
uml/amd64 in this case)
	* figured out that one can send a reference to branch in git tree
(with summary/shortlog/diffstat) using somewhat less than 140KB...

Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow

[Joe Perches]

On Mon, 2007-08-20 at 00:33 +0200, Jan Engelhardt wrote:
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)

Should any file in include/ have a line like:

	#include "[path/]file"

Shouldn't these all be

	#include <path/file>

?