RE: Re: [PATCH] pps: add epoll support

[Denis OSTERLAND-HEIM <denis.osterland@diehl.com>]

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]

Hi,

> -----Original Message-----
> From: Rodolfo Giometti <giometti@enneenne.com> 
> Sent: Tuesday, February 25, 2025 3:24 PM
> To: Denis OSTERLAND-HEIM <denis.osterland@diehl.com>
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] pps: add epoll support
>  
[snip]
> 
> > If I start multiple user space programs data races are visible.
> > 
> > ```
> > # for i in 0 1 2 3 4 5 6; do PpsPollTest /dev/pps1 > log$i & done
> > # sleep 6
> > # tail log*
> > ==> log0 <==
> > timeout
> > assert: 196
> > time: 1520599554.276752928
> > assert: 197
> > time: 1520599555.300692704
> 
> This is the same behavior we have when working with a serial port: if more than 
> one process gets access to it, data is stolen.
Okay, then lets choose your suggestion.

> 
> >>From my point of view it would be great to fix this bug without such an limitation.
> 
> I disagree, it is not a limitation! It is like a normal char device work.
> 
> What we have to test now is if your initial goal has been addressed! That is, in 
> an application that has more to do than just dealing with one PPS device, we can 
> use poll()/select() in order to avoid using threads.
I will do the final test.
I expect that it works with your patch.

Shall I prepare the patch?
Shall I add you as Co-author?
Or do you want to send your patch with me in reported-by and tested-by?

Fixes: eae9d2ba0cfc ("LinuxPPS: core support")?

CC stable?

Regards, Denis

> 
> Ciao,
> 
> Rodolfo
> 
> -- 
> GNU/Linux Solutions                  e-mail: giometti@enneenne.com
> Linux Device Driver                          giometti@linux.it
> Embedded Systems                     phone:  +39 349 2432127
> UNIX programming
>

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6038 bytes --]