* [PATCH] mm: fix exit_mmap BUG() on a.out binary exit
@ 2007-12-20 8:47 Ivan Kokshaysky
2007-12-20 9:19 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Kokshaysky @ 2007-12-20 8:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
The problem was introduced by commit "mm: variable length argument
support" (b6a2fea39318e43fee84fa7b0b90d68bed92d2ba)
as it didn't update fs/binfmt_aout.c like other binfmt's.
I noticed that on alpha when accidentally launched old OSF/1
Acrobat Reader binary. Obviously, other architectures are affected
as well.
Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
---
fs/binfmt_aout.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
index e176d19..7596e1e 100644
--- a/fs/binfmt_aout.c
+++ b/fs/binfmt_aout.c
@@ -319,7 +319,6 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs)
current->mm->free_area_cache = current->mm->mmap_base;
current->mm->cached_hole_size = 0;
- current->mm->mmap = NULL;
compute_creds(bprm);
current->flags &= ~PF_FORKNOEXEC;
#ifdef __sparc__
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: fix exit_mmap BUG() on a.out binary exit
2007-12-20 8:47 [PATCH] mm: fix exit_mmap BUG() on a.out binary exit Ivan Kokshaysky
@ 2007-12-20 9:19 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2007-12-20 9:19 UTC (permalink / raw)
To: Ivan Kokshaysky; +Cc: Andrew Morton, linux-kernel, Linus Torvalds
On Thu, 2007-12-20 at 11:47 +0300, Ivan Kokshaysky wrote:
> The problem was introduced by commit "mm: variable length argument
> support" (b6a2fea39318e43fee84fa7b0b90d68bed92d2ba)
> as it didn't update fs/binfmt_aout.c like other binfmt's.
>
> I noticed that on alpha when accidentally launched old OSF/1
> Acrobat Reader binary. Obviously, other architectures are affected
> as well.
>
> Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
.24 material I'd say.
> ---
> fs/binfmt_aout.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index e176d19..7596e1e 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -319,7 +319,6 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs)
> current->mm->free_area_cache = current->mm->mmap_base;
> current->mm->cached_hole_size = 0;
>
> - current->mm->mmap = NULL;
> compute_creds(bprm);
> current->flags &= ~PF_FORKNOEXEC;
> #ifdef __sparc__
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-20 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-20 8:47 [PATCH] mm: fix exit_mmap BUG() on a.out binary exit Ivan Kokshaysky
2007-12-20 9:19 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox