From: John Stultz <johnstul@us.ibm.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] Keep track of original clocksource frequency
Date: Wed, 02 Apr 2008 08:38:37 -0700 [thread overview]
Message-ID: <1207150717.6211.0.camel@jstultz-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0804021314400.26791@localhost.localdomain>
On Wed, 2008-04-02 at 13:20 +0200, Roman Zippel wrote:
> Hi,
>
> On Tue, 18 Mar 2008, john stultz wrote:
>
> > @@ -63,6 +64,7 @@ struct clocksource {
> > cycle_t (*read)(void);
> > cycle_t mask;
> > u32 mult;
> > + s32 mult_orig;
> > u32 shift;
> > unsigned long flags;
> > cycle_t (*vread)(void);
>
> This is wrong, with HZ=100 the jiffies clock multiplier suddenly becomes
> negative and later the raw interval underflows.
Ah, thanks for catching that!
>
> Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Acked-by: John Stultz <johnstul@us.ibm.com>
prev parent reply other threads:[~2008-04-02 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 22:11 [PATCH 1/2] Keep track of original clocksource frequency john stultz
2008-03-18 22:13 ` [PATCH 2/2] Introduce CLOCK_MONOTONIC_RAW john stultz
2008-03-19 2:43 ` Andrew Morton
2008-03-19 3:01 ` john stultz
2008-04-02 11:39 ` [PATCH 1/2] Introduce clocksource_forward_now Roman Zippel
2008-04-02 16:01 ` John Stultz
2008-04-03 21:07 ` Andrew Morton
2008-04-02 11:50 ` [PATCH 2/2] Introduce CLOCK_MONOTONIC_RAW Roman Zippel
2008-04-02 16:01 ` John Stultz
2008-04-02 16:37 ` Roman Zippel
2008-04-03 21:11 ` Andrew Morton
2008-04-02 11:20 ` [PATCH 1/2] Keep track of original clocksource frequency Roman Zippel
2008-04-02 15:38 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207150717.6211.0.camel@jstultz-laptop \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox