From: Roman Zippel <zippel@linux-m68k.org>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] Keep track of original clocksource frequency
Date: Wed, 2 Apr 2008 13:20:07 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0804021314400.26791@localhost.localdomain> (raw)
In-Reply-To: <1205878279.28128.114.camel@localhost>
Hi,
On Tue, 18 Mar 2008, john stultz wrote:
> @@ -63,6 +64,7 @@ struct clocksource {
> cycle_t (*read)(void);
> cycle_t mask;
> u32 mult;
> + s32 mult_orig;
> u32 shift;
> unsigned long flags;
> cycle_t (*vread)(void);
This is wrong, with HZ=100 the jiffies clock multiplier suddenly becomes
negative and later the raw interval underflows.
bye, Roman
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
---
include/linux/clocksource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/include/linux/clocksource.h
===================================================================
--- linux-2.6.orig/include/linux/clocksource.h
+++ linux-2.6/include/linux/clocksource.h
@@ -64,7 +64,7 @@ struct clocksource {
cycle_t (*read)(void);
cycle_t mask;
u32 mult;
- s32 mult_orig;
+ u32 mult_orig;
u32 shift;
unsigned long flags;
cycle_t (*vread)(void);
next prev parent reply other threads:[~2008-04-02 11:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 22:11 [PATCH 1/2] Keep track of original clocksource frequency john stultz
2008-03-18 22:13 ` [PATCH 2/2] Introduce CLOCK_MONOTONIC_RAW john stultz
2008-03-19 2:43 ` Andrew Morton
2008-03-19 3:01 ` john stultz
2008-04-02 11:39 ` [PATCH 1/2] Introduce clocksource_forward_now Roman Zippel
2008-04-02 16:01 ` John Stultz
2008-04-03 21:07 ` Andrew Morton
2008-04-02 11:50 ` [PATCH 2/2] Introduce CLOCK_MONOTONIC_RAW Roman Zippel
2008-04-02 16:01 ` John Stultz
2008-04-02 16:37 ` Roman Zippel
2008-04-03 21:11 ` Andrew Morton
2008-04-02 11:20 ` Roman Zippel [this message]
2008-04-02 15:38 ` [PATCH 1/2] Keep track of original clocksource frequency John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804021314400.26791@localhost.localdomain \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox