Re: [PATCH] introduce HAVE_EFFICIENT_UNALIGNED_ACCESS Kconfig symbol

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Stefan,

Thanks for the text review. I'll follow up with a new version in a
minute.

> > --- everything.orig/arch/Kconfig	2008-04-04 23:42:50.000000000 +0200
> > +++ everything/arch/Kconfig	2008-04-04 23:52:15.000000000 +0200
> > @@ -36,3 +36,22 @@ config HAVE_KPROBES
> >  
> >  config HAVE_KRETPROBES
> >  	def_bool n
> > +
> > +config HAVE_EFFICIENT_UNALIGNED_ACCESS
> > +	def_bool n
> > +	help
> > +	  Some architectures are unable to perform unaligned accesses
> > +	  without the use of get_unaligned/put_unaligned. Others are
> > +	  unable to perform such accesses efficiently (e.g. trap on
> 
> Wouldn't a comment be more appropriate instead of a help text?  This
> option shouldn't be a visible make XYZconfig prompt.
> 
> I have no comment on the option itself; it's not my domain.

Note that the help text doesn't mean the option gets to be visible, only
the one-line description does, as in

config XYZ
	bool "description"

vs.
config XYZ
	bool

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]