From: Jon Tollefson <kniht@linux.vnet.ibm.com>
To: npiggin@suse.de
Cc: akpm@linux-foundation.org, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, pj@sgi.com,
andi@firstfloor.org, kniht@linux.vnet.ibm.com
Subject: Re: [patch 01/17] hugetlb: modular state
Date: Mon, 21 Apr 2008 15:51:24 -0500 [thread overview]
Message-ID: <1208811084.11866.10.camel@skynet> (raw)
In-Reply-To: <20080410171100.425293000@nick.local0.net>
On Fri, 2008-04-11 at 03:02 +1000, npiggin@suse.de wrote:
<snip>
> Index: linux-2.6/include/linux/hugetlb.h
> ===================================================================
> --- linux-2.6.orig/include/linux/hugetlb.h
> +++ linux-2.6/include/linux/hugetlb.h
> @@ -40,7 +40,7 @@ extern int sysctl_hugetlb_shm_group;
>
> /* arch callbacks */
>
> -pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr);
> +pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr, int sz);
<snip>
The sz here needs to be a long to handle sizes such as 16G on powerpc.
There are other places in hugetlb.c where the size also needs to be a
long, but this one affects the arch code too since it is public.
Jon
Tollefson
next prev parent reply other threads:[~2008-04-21 20:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080410170232.015351000@nick.local0.net>
[not found] ` <20080410171101.395469000@nick.local0.net>
2008-04-10 17:33 ` [patch 10/17] mm: fix bootmem alignment Yinghai Lu
2008-04-10 17:39 ` Nick Piggin
2008-04-11 11:58 ` Nick Piggin
2008-04-10 23:59 ` [patch 00/17] multi size, and giant hugetlb page support, 1GB hugetlb for x86 Nish Aravamudan
2008-04-11 8:28 ` Nick Piggin
2008-04-11 19:57 ` Nish Aravamudan
[not found] ` <20080410171101.551336000@nick.local0.net>
2008-04-11 8:13 ` [patch 11/17] hugetlbfs: support larger than MAX_ORDER Andi Kleen
2008-04-11 8:59 ` Nick Piggin
[not found] ` <20080410171100.425293000@nick.local0.net>
2008-04-21 20:51 ` Jon Tollefson [this message]
2008-04-22 6:45 ` [patch 01/17] hugetlb: modular state Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208811084.11866.10.camel@skynet \
--to=kniht@linux.vnet.ibm.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox