From: Nick Piggin <npiggin@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, pj@sgi.com,
kniht@linux.vnet.ibm.com
Subject: Re: [patch 11/17] hugetlbfs: support larger than MAX_ORDER
Date: Fri, 11 Apr 2008 10:59:28 +0200 [thread overview]
Message-ID: <20080411085928.GC20253@wotan.suse.de> (raw)
In-Reply-To: <20080411081317.GQ10019@one.firstfloor.org>
On Fri, Apr 11, 2008 at 10:13:17AM +0200, Andi Kleen wrote:
> > spin_lock(&hugetlb_lock);
> > - if (h->surplus_huge_pages_node[nid]) {
> > + if (h->surplus_huge_pages_node[nid] && h->order <= MAX_ORDER) {
>
> As Andrew Hastings pointed out earlier this all needs to be h->order < MAX_ORDER
> [got pretty much all the checks wrong off by one]. It won't affect anything
> on x86-64 but might cause problems on archs which have exactly MAX_ORDER
> sized huge pages.
Ah, hmm, I might have missed a couple of emails worth of feedback when
you last posted. Thanks for pointing this out, I'll read over them again.
next prev parent reply other threads:[~2008-04-11 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080410170232.015351000@nick.local0.net>
[not found] ` <20080410171101.395469000@nick.local0.net>
2008-04-10 17:33 ` [patch 10/17] mm: fix bootmem alignment Yinghai Lu
2008-04-10 17:39 ` Nick Piggin
2008-04-11 11:58 ` Nick Piggin
2008-04-10 23:59 ` [patch 00/17] multi size, and giant hugetlb page support, 1GB hugetlb for x86 Nish Aravamudan
2008-04-11 8:28 ` Nick Piggin
2008-04-11 19:57 ` Nish Aravamudan
[not found] ` <20080410171101.551336000@nick.local0.net>
2008-04-11 8:13 ` [patch 11/17] hugetlbfs: support larger than MAX_ORDER Andi Kleen
2008-04-11 8:59 ` Nick Piggin [this message]
[not found] ` <20080410171100.425293000@nick.local0.net>
2008-04-21 20:51 ` [patch 01/17] hugetlb: modular state Jon Tollefson
2008-04-22 6:45 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411085928.GC20253@wotan.suse.de \
--to=npiggin@suse.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=kniht@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox