Re: [PATCH] or51132.c: unaligned

[Harvey Harrison <harvey.harrison@gmail.com>]

On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  drivers/media/dvb/frontends/or51132.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/dvb/frontends/or51132.c b/drivers/media/dvb/frontends/or51132.c
> index c7b5785..5ed3254 100644
> --- a/drivers/media/dvb/frontends/or51132.c
> +++ b/drivers/media/dvb/frontends/or51132.c
> @@ -126,7 +126,7 @@ static int or51132_readreg(struct or51132_state *state, u8 reg)
>  		       reg, err);
>  		return -EREMOTEIO;
>  	}
> -	return le16_to_cpup((u16*)buf);
> +	return buf[0] | (buf[1] << 8);

return get_unaligned_le16(buf);

>  }
>  
>  static int or51132_load_firmware (struct dvb_frontend* fe, const struct firmware *fw)
> @@ -140,9 +140,9 @@ static int or51132_load_firmware (struct dvb_frontend* fe, const struct firmware
>  	dprintk("Firmware is %Zd bytes\n",fw->size);
>  
>  	/* Get size of firmware A and B */
> -	firmwareAsize = le32_to_cpu(*((u32*)fw->data));
> +	firmwareAsize = le32_to_cpu(*((__le32*)fw->data));

firmwareAsize = le32_to_cpup((__le32 *)fw->data);

>  	dprintk("FirmwareA is %i bytes\n",firmwareAsize);
> -	firmwareBsize = le32_to_cpu(*((u32*)(fw->data+4)));
> +	firmwareBsize = le32_to_cpu(*((__le32*)(fw->data+4)));

firmwareBsize = le32_to_cpup((__le32 *)(fw->data + 4));

Cheers,

Harvey