From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Al Viro <viro@ftp.linux.org.uk>,
mchehab@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] or51132.c: unaligned
Date: Wed, 21 May 2008 02:18:43 +0100 [thread overview]
Message-ID: <20080521011843.GH28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.1.10.0805201752230.3081@woody.linux-foundation.org>
On Tue, May 20, 2008 at 05:55:38PM -0700, Linus Torvalds wrote:
> > > > + return buf[0] | (buf[1] << 8);
> > >
> > > return get_unaligned_le16(buf);
> >
> > And the point of that would be?
>
> Perhaps better code generation?
FWIW, I wonder how they really compare on misaligned and whether it would
make sense for gcc to try and generate a single load on targets that are
known to allow that...
Hell knows; I still find explicit variant more readable in this case and
AFAICS it's not a critical path...
next prev parent reply other threads:[~2008-05-21 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 0:33 [PATCH] or51132.c: unaligned Al Viro
2008-05-21 0:41 ` Harvey Harrison
2008-05-21 0:45 ` Al Viro
2008-05-21 0:51 ` Harvey Harrison
2008-05-21 0:56 ` Al Viro
2008-05-21 0:55 ` Linus Torvalds
2008-05-21 1:18 ` Al Viro [this message]
2008-05-21 2:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521011843.GH28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox