The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Dave Airlie <airlied@gmail.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.sourceforge.net>
Subject: Re: in-kernel DRM tree move around....
Date: Thu, 29 May 2008 12:41:25 -0700	[thread overview]
Message-ID: <1212090086.2563.42.camel@localhost> (raw)
In-Reply-To: <21d7e9970805281746k71b47ed2i79c06288d2dca022@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

On Thu, 2008-05-29 at 10:46 +1000, Dave Airlie wrote:
> Hi,
> 
> So I've been growing more annoyed with the current layout of the drm
> tree in the kernel,
> 
> a) it lives under char.
> b) everything in one directory.
> c) header files in one directory.
> d) no header files exposed to userspace.
> 
> http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=7df9a948d0f849466e3de259cccb49bc54cbad68
> 
> is a proposal to create drivers/gpu/drm, (I may move AGP in there as
> well later). It also creates per-driver subdirs.
> 
> This to me solves the a-d problems.
> 
> There is also an out-of-tree kernel drm which I'll probably give some
> more thought later.

I like it.

For upstream DRM, my first thought was something like:

drm/src/i915/i915_*.[ch]
drm/src/r128/r128_*.[ch]
drm/src/drm.h
drm/src/bsd/drm_*.[ch]
drm/src/bsd/Makefile
drm/src/bsd/i915/Makefile
drm/src/bsd/r128/Makefile
drm/src/linux/drm_*.[ch]
drm/src/linux/Makefile

Get rid of the -core absurdity, and move the shared code to top-level of
the kernel instead of alongside other kernel code.

But maybe nicer for merging on both of our parts would be:

drm/linux/Makefile
drm/linux/drm*.[ch]
drm/linux/i915/Makefile
drm/linux/i915/i915_*.[ch]
drm/linux/i915/Makefile
drm/linux/r128/r128_*.[ch]
drm/bsd/drm.h -> ../linux/drm.h
drm/bsd/drm*.[ch]
drm/bsd/Makefile
drm/bsd/i915/Makefile
drm/bsd/i915/i915_drv.c
drm/bsd/i915/i915_*.[ch] -> ../../linux/i915/i915_*.[ch]
drm/bsd/r128/Makefile
drm/bsd/r128/r128_drv.c
drm/bsd/r128/r128_*.[ch] -> ../../linux/r128/r128_*.[ch]

-- 
Eric Anholt                             anholt@FreeBSD.org
eric@anholt.net                         eric.anholt@intel.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2008-06-03  0:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29  0:46 in-kernel DRM tree move around Dave Airlie
2008-05-29  4:23 ` Sam Ravnborg
2008-05-29  5:23   ` Dave Airlie
2008-05-29  7:33     ` Sam Ravnborg
2008-05-29  8:20   ` Jan Engelhardt
2008-05-29  9:05 ` Alexander van Heukelum
2008-05-29 10:34   ` Alan Cox
2008-05-29 11:02 ` David Woodhouse
2008-05-30  6:26   ` Dave Airlie
2008-05-30 16:58     ` Jesse Barnes
2008-05-29 19:41 ` Eric Anholt [this message]
2008-06-01 14:57 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212090086.2563.42.camel@localhost \
    --to=eric@anholt.net \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox