From: Richard Purdie <rpurdie@rpsys.net>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Linux ARM Kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Arnaud Patard <arnaud.patard@rtp-net.org>
Subject: Re: [patch 4/5] sparse: leds-h1940.c: make non-exported symbols static
Date: Mon, 09 Jun 2008 22:02:47 +0100 [thread overview]
Message-ID: <1213045367.5026.66.camel@dax.rpnet.com> (raw)
In-Reply-To: <20080607153712.202340716@fluff.org.uk>
On Sat, 2008-06-07 at 16:36 +0100, Ben Dooks wrote:
> plain text document attachment (sparse-fix-h1940-leds.patch)
> We do not need to export any of the routines inside
> drivers/leds/leds-h1940.c, so make them all static to
> quieten the sparse output for this driver.
>
> Fixes the following sparse errors:
> drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static?
>
> CC: Richard Purdie <rpurdie@rpsys.net>
> CC: Linux Kernel <linux-kernel@vger.kernel.org>
> CC: Arnaud Patard <arnaud.patard@rtp-net.org>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Queued in the LEDs tree, thanks.
Richard
prev parent reply other threads:[~2008-06-09 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080607153655.026170849@fluff.org.uk>
2008-06-07 15:36 ` [patch 4/5] sparse: leds-h1940.c: make non-exported symbols static Ben Dooks
2008-06-09 21:02 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213045367.5026.66.camel@dax.rpnet.com \
--to=rpurdie@rpsys.net \
--cc=arnaud.patard@rtp-net.org \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox