From: Ben Dooks <ben-linux@fluff.org>
To: Linux ARM Kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Ben Dooks <ben-linux@fluff.org>
Subject: [patch 4/5] sparse: leds-h1940.c: make non-exported symbols static
Date: Sat, 07 Jun 2008 16:36:59 +0100 [thread overview]
Message-ID: <20080607153712.202340716@fluff.org.uk> (raw)
In-Reply-To: 20080607153655.026170849@fluff.org.uk
[-- Attachment #1: sparse-fix-h1940-leds.patch --]
[-- Type: text/plain, Size: 1954 bytes --]
We do not need to export any of the routines inside
drivers/leds/leds-h1940.c, so make them all static to
quieten the sparse output for this driver.
Fixes the following sparse errors:
drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static?
drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static?
drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static?
CC: Richard Purdie <rpurdie@rpsys.net>
CC: Linux Kernel <linux-kernel@vger.kernel.org>
CC: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc5/drivers/leds/leds-h1940.c
===================================================================
--- linux-2.6.26-rc5.orig/drivers/leds/leds-h1940.c 2008-06-07 16:12:19.000000000 +0100
+++ linux-2.6.26-rc5/drivers/leds/leds-h1940.c 2008-06-07 16:13:18.000000000 +0100
@@ -23,7 +23,8 @@
/*
* Green led.
*/
-void h1940_greenled_set(struct led_classdev *led_dev, enum led_brightness value)
+static void h1940_greenled_set(struct led_classdev *led_dev,
+ enum led_brightness value)
{
switch (value) {
case LED_HALF:
@@ -52,7 +53,8 @@ static struct led_classdev h1940_greenle
/*
* Red led.
*/
-void h1940_redled_set(struct led_classdev *led_dev, enum led_brightness value)
+static void h1940_redled_set(struct led_classdev *led_dev,
+ enum led_brightness value)
{
switch (value) {
case LED_HALF:
@@ -82,7 +84,8 @@ static struct led_classdev h1940_redled
* Blue led.
* (it can only be blue flashing led)
*/
-void h1940_blueled_set(struct led_classdev *led_dev, enum led_brightness value)
+static void h1940_blueled_set(struct led_classdev *led_dev,
+ enum led_brightness value)
{
if (value) {
/* flashing Blue */
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next parent reply other threads:[~2008-06-07 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080607153655.026170849@fluff.org.uk>
2008-06-07 15:36 ` Ben Dooks [this message]
2008-06-09 21:02 ` [patch 4/5] sparse: leds-h1940.c: make non-exported symbols static Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607153712.202340716@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=arnaud.patard@rtp-net.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox