From: Ben Collins <ben.collins@canonical.com>
To: usb-storage <usb-storage@lists.one-eyed-alien.net>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Ambiguous dupe in libusual device list
Date: Thu, 26 Jun 2008 13:32:36 -0400 [thread overview]
Message-ID: <1214501556.7150.36.camel@cunning> (raw)
In unusual_devs.h, there are these two entries:
#ifdef CONFIG_USB_STORAGE_DATAFAB
/* Submitted by Olaf Hering <olh@suse.de> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
"Datafab Systems, Inc.",
"USB to CF + SM Combo (LC1)",
US_SC_SCSI, US_PR_DATAFAB, NULL,
0 ),
#endif
#ifdef CONFIG_USB_STORAGE_SDDR55
/* SM part - aeb <Andries.Brouwer@cwi.nl> */
UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
"Datafab Systems, Inc.",
"USB to CF + SM Combo (LC1)",
US_SC_SCSI, US_PR_SDDR55, NULL,
US_FL_SINGLE_LUN ),
#endif
If I'm not mistaken (and because libusual is pretty well abstracted, I
might be) this is an ambiguous dupe that isn't resolved with any
checking (IOW, the second entry is likely never used), at least when
both config options are enabled.
If that's not the case, then maybe a comment would be in order? If the
case is that these two options should not be enabled at the same time,
then perhaps some Kconfig magic is required.
next reply other threads:[~2008-06-26 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 17:32 Ben Collins [this message]
2008-06-26 19:10 ` [usb-storage] Ambiguous dupe in libusual device list Matthew Dharm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214501556.7150.36.camel@cunning \
--to=ben.collins@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox