From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Ben Collins <ben.collins@canonical.com>
Cc: usb-storage <usb-storage@lists.one-eyed-alien.net>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [usb-storage] Ambiguous dupe in libusual device list
Date: Thu, 26 Jun 2008 12:10:10 -0700 [thread overview]
Message-ID: <20080626191010.GD31004@one-eyed-alien.net> (raw)
In-Reply-To: <1214501556.7150.36.camel@cunning>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
On Thu, Jun 26, 2008 at 01:32:36PM -0400, Ben Collins wrote:
> In unusual_devs.h, there are these two entries:
>
> #ifdef CONFIG_USB_STORAGE_DATAFAB
> /* Submitted by Olaf Hering <olh@suse.de> */
> UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
> #ifdef CONFIG_USB_STORAGE_SDDR55
> /* SM part - aeb <Andries.Brouwer@cwi.nl> */
> UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff,
> If I'm not mistaken (and because libusual is pretty well abstracted, I
> might be) this is an ambiguous dupe that isn't resolved with any
> checking (IOW, the second entry is likely never used), at least when
> both config options are enabled.
Reading the code, it looks like it's a bit more complex than that.
The first entry enables use of a driver (if it's compiled it) which can
drive both slots on a dual-slot device.
The first entry enables use of a driver (if it's compiled it) which can
only drive one slot on a dual-slot device.
This is really the type of thing which shows that we need some sort of
semi-generic "preference" mechanism for driver binding...
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
M: No, Windows doesn't have any nag screens.
C: Then what are those blue and white screens I get every day?
-- Mike and Cobb
User Friendly, 1/4/1999
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-06-26 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 17:32 Ambiguous dupe in libusual device list Ben Collins
2008-06-26 19:10 ` Matthew Dharm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626191010.GD31004@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=ben.collins@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox